Messages in this thread | | | From | Stephen Warren <> | Date | Thu, 11 Aug 2011 10:14:17 -0700 | Subject | RE: [PATCH RESEND] Input: tegra-kbc - correct call to input_free_device |
| |
Dmitry Torokhov wrote at Thursday, August 11, 2011 10:52 AM: > On Thu, Aug 11, 2011 at 09:42:54AM -0700, Stephen Warren wrote: > > Axel Lin wrote at Thursday, August 11, 2011 2:49 AM: > > > If kzalloc for kbc fails, then we have NULL pointer dereference while > > > calling input_free_device(kbc->idev) in the error handling. > > > So it is safer to always use the original name, input_dev. > > > > > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > > > > Reviewed-by: Stephen Warren <swarren@nvidia.com> > > Gah, sorry, already pushed into my public branch so won't be able so > add your reviewed-by...
No worries; you had no reason to expect anyone to review it!
-- nvpublic
| |