Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH] drivers/scsi/mpt2sas/mpt2sas_transport.c: add missing sas_phy_free | Date | Wed, 10 Aug 2011 13:32:13 +0200 |
| |
From: Julia Lawall <julia@diku.dk>
In each case, sas_phy_add has not yet been successfully applied, so use sas_phy_free to free phy.
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/scsi/mpt2sas/mpt2sas_transport.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c index 15c7980..762f05e 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c @@ -857,6 +857,7 @@ mpt2sas_transport_add_host_phy(struct MPT2SAS_ADAPTER *ioc, struct _sas_phy &mpt2sas_phy->identify))) { printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", ioc->name, __FILE__, __LINE__, __func__); + sas_phy_free(phy); return -1; } phy->identify = mpt2sas_phy->identify; @@ -923,6 +924,7 @@ mpt2sas_transport_add_expander_phy(struct MPT2SAS_ADAPTER *ioc, struct _sas_phy &mpt2sas_phy->identify))) { printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", ioc->name, __FILE__, __LINE__, __func__); + sas_phy_free(phy); return -1; } phy->identify = mpt2sas_phy->identify;
| |