Messages in this thread | | | Date | Thu, 7 Jul 2011 13:22:42 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH v3] Add support for the Philips SA56004 temperature sensor. |
| |
On Sun, 26 Jun 2011 21:54:37 +0200, Fubo Chen wrote: > On Mon, Jun 6, 2011 at 12:40 PM, <sdevrien@cisco.com> wrote: > > + } else > > + if (man_id == 0xA1) { /* NXP Semiconductor/Philips */ > > No kernel coder writes like this. Has this ever been run through checkpatch ?
Actually, I wrote that code, and I am a kernel coder. You may not like it, but at the time it seemed the best way to keep the function readable. This particular style allows for better placement of comments, which are many in this function.
As long as checkpatch doesn't complain about it, I will not consider changing it, and will reject any attempt to do so (simply by comparing the readability before and after the patch and inevitably coming up to the conclusion that the change isn't worth it.)
-- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |