Messages in this thread | | | Subject | RE: [PATCH v3] Add support for the Philips SA56004 temperature sensor. | Date | Mon, 27 Jun 2011 09:04:46 +0200 | From | "Stijn Devriendt (sdevrien)" <> |
| |
> On Mon, Jun 6, 2011 at 12:40 PM, <sdevrien@cisco.com> wrote: > > + } else > > + if (man_id == 0xA1) { /* NXP Semiconductor/Philips */ > > No kernel coder writes like this. Has this ever been run through > checkpatch ? It has. Unfortunately this is just the coding style in the whole driver. I believe it's better to have a consistent file rather than 3 different styles.
Stijn
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |