Messages in this thread | | | Date | Wed, 6 Jul 2011 16:33:12 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] panic, vt: do not force oops output when panic_timeout < 0 |
| |
On Wed, 22 Jun 2011 15:30:39 -0700 Mandeep Singh Baines <msb@chromium.org> wrote:
> Mandeep Singh Baines (msb@chromium.org) wrote: > > Avoid risk (of screen_unblank) and wasted cycles unblanking if > > you intend to reboot immediately. > > > > The original patch doesn't work. It worked fine when I tested with > a serial port. When I disabled the serial out, my machine started to > get wedged on a panic. I guess screen_unblank was in bust_spinlocks > for a reason. It probably bust some spin_locks somewhere. > > Below is a replacement for this patch which calls screen_unblank but > does not force output when the panic timeout is negative (no wait). > > -- >8 -- (snip) > > Don't force output if you intend to reboot immediately. > > This patch depends on: > > http://lkml.kernel.org/r/1308612129-12488-1-git-send-email-msb@chromium.org
Please fold this into that and resend the patch series. Please add the needed update to Documentation/kernel-parameters.txt.
| |