lkml.org 
[lkml]   [2011]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] panic, vt: do not force oops output when panic_timeout < 0
    Mandeep Singh Baines (msb@chromium.org) wrote:
    > Avoid risk (of screen_unblank) and wasted cycles unblanking if
    > you intend to reboot immediately.
    >

    The original patch doesn't work. It worked fine when I tested with
    a serial port. When I disabled the serial out, my machine started to
    get wedged on a panic. I guess screen_unblank was in bust_spinlocks
    for a reason. It probably bust some spin_locks somewhere.

    Below is a replacement for this patch which calls screen_unblank but
    does not force output when the panic timeout is negative (no wait).

    -- >8 -- (snip)

    Don't force output if you intend to reboot immediately.

    This patch depends on:

    http://lkml.kernel.org/r/1308612129-12488-1-git-send-email-msb@chromium.org

    Change-Id: I48f86746ac36d420b1b025197f50d5d56b873e9f
    Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Huang Ying <ying.huang@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Olaf Hering <olaf@aepfle.de>
    Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
    Cc: Dave Airlie <airlied@gmail.com>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    include/linux/vt_kern.h | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
    index 4d05e14..c2164fa 100644
    --- a/include/linux/vt_kern.h
    +++ b/include/linux/vt_kern.h
    @@ -137,7 +137,7 @@ int vty_init(const struct file_operations *console_fops);

    static inline bool vt_force_oops_output(struct vc_data *vc)
    {
    - if (oops_in_progress && vc->vc_panic_force_write)
    + if (oops_in_progress && vc->vc_panic_force_write && panic_timeout >= 0)
    return true;
    return false;
    }
    --
    1.7.3.1


    \
     
     \ /
      Last update: 2011-06-23 00:33    [W:0.031 / U:31.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site