lkml.org 
[lkml]   [2011]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and warnings
    Date


    > -----Original Message-----
    > From: Joe Perches [mailto:joe@perches.com]
    > Sent: Tuesday, July 19, 2011 3:29 PM
    > To: KY Srinivasan
    > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
    > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
    > Subject: Re: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and
    > warnings
    >
    > On Tue, 2011-07-19 at 11:44 -0700, K. Y. Srinivasan wrote:
    > > Fix checkpatch errors and warnings.
    > []
    > > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
    > []
    > > @@ -53,7 +53,7 @@ struct hv_input_dev_info {
    > > -#pragma pack(push,1)
    > > +#pragma pack(push, 1)
    > > /*
    > > * Message types in the synthetic input protocol
    > > */
    >
    > Perhaps it's better and more consistent with
    > other kernel style uses to remove #pragma pack[...]
    > and mark the individual structs with __packed;

    Good point. Currently, this driver is not functional. When the driver
    is finally functional, there is a whole lot of cleanup that is needed and I will
    do what you are suggesting then. For this go around, I just wanted to address
    checkpatch issues with minimal change.

    Regards,

    K. Y

    \
     
     \ /
      Last update: 2011-07-20 00:49    [W:0.030 / U:30.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site