lkml.org 
[lkml]   [2011]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/8] Staging: hv: mousevsc: Fix checkpatch errors and warnings
    From
    Date
    On Tue, 2011-07-19 at 11:44 -0700, K. Y. Srinivasan wrote:
    > Fix checkpatch errors and warnings.
    []
    > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
    []
    > @@ -53,7 +53,7 @@ struct hv_input_dev_info {
    > -#pragma pack(push,1)
    > +#pragma pack(push, 1)
    > /*
    > * Message types in the synthetic input protocol
    > */

    Perhaps it's better and more consistent with
    other kernel style uses to remove #pragma pack[...]
    and mark the individual structs with __packed;

    $ grep -rP --include=*.[ch] "pragma.*pack" * | wc -l
    221
    $ grep -rP --include=*.[ch] "(__attribute__.*packed|\b__packed\b)" * | wc -l
    5553




    \
     
     \ /
      Last update: 2011-07-19 21:31    [W:0.019 / U:95.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site