lkml.org 
[lkml]   [2011]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subject[rfc] Remove member .name from struct netpoll
From
Date
struct netpoll has member .name

struct netpoll {
struct net_device *dev;
char dev_name[IFNAMSIZ];
const char *name;
[...]
};

that is set only by netconsole.c

static struct netconsole_target *alloc_param_target(char *target_config)
{
[...]
nt->np.name = "netconsole";

and used only by net/core/netpoll.c to emit "netconsole: " on
logging messages.

e.g.

void netpoll_print_options(struct netpoll *np)
{
printk(KERN_INFO "%s: local port %d\n",
np->name, np->local_port);

I think it'd be more common to use pr_fmt and pr_<level>
to emit these logging messages.

Are there out of tree users or plans to use "struct netpoll"
by other modules?

If not, I propose to remove name from the struct.



\
 
 \ /
  Last update: 2011-07-01 19:11    [W:1.195 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site