lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] [PATCH] x86: Make copy_from_user_nmi() a library function
    On Tue, Jun 07, 2011 at 07:24:13PM +0200, Robert Richter wrote:
    ... (unrelated a bit) ...
    > +
    > + offset = addr & (PAGE_SIZE - 1);
    > + size = min(PAGE_SIZE - offset, n - len);
    > +
    ...

    Robert, would not offset = addr & ~PAGE_MASK be somehow more
    readable? Just a thought.

    Cyrill


    \
     
     \ /
      Last update: 2011-06-07 22:49    [W:0.020 / U:33.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site