lkml.org 
[lkml]   [2011]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter
On Tue, 7 Jun 2011, Tanya Brokhman wrote:

> > You might want to print out some kind of error message if the user
> > specifies is_super_speed = True and is_high_speed = False.
> >
>
> I thought about that as well. Even added it but removed at the last minute
> :) I encountered quite a few places in the code where some error message to
> the user is really needed but is missing

What other places? There is very little the user has to do with
dummy-hcd -- really nothing more than setting the module parameters.

> so my impression was that it's best
> to keep the printks to a minimum. Isn't that the general approach? IMO, in
> this particular case informing the user isn't a "must". If you feel strongly
> about it I can add the message.

IMO the driver should print an error message and fail to load if there
are contradictory module parameters.

Alan Stern



\
 
 \ /
  Last update: 2011-06-07 15:47    [W:0.089 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site