Messages in this thread | | | From | "Tanya Brokhman" <> | Subject | RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter | Date | Tue, 7 Jun 2011 07:55:14 +0300 |
| |
> > You might want to print out some kind of error message if the user > specifies is_super_speed = True and is_high_speed = False. >
I thought about that as well. Even added it but removed at the last minute :) I encountered quite a few places in the code where some error message to the user is really needed but is missing so my impression was that it's best to keep the printks to a minimum. Isn't that the general approach? IMO, in this particular case informing the user isn't a "must". If you feel strongly about it I can add the message.
Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |