Messages in this thread | | | Date | Thu, 16 Jun 2011 22:58:25 -0400 (EDT) | Subject | Re: [PATCH] macvtap: remove wrong sock_put() in macvtap_put_queue() | From | David Miller <> |
| |
From: Jason Wang <jasowang@redhat.com> Date: Mon, 13 Jun 2011 11:15:19 +0800
> The calling of sock_put() should be delayed after synchronize_rcu(), > otherwise inconsist data may be seen during packets transmitting. > > Signed-off-by: Jason Wang <jasowang@redhat.com>
You're leaking sockets now.
This function has to release the socket twice if there is a non-NULL vlan assigned to the queue.
Now you're only doing it once in that situation.
Which probably fixes your crash, but adds a socket leak.
| |