Messages in this thread Patch in this message | | | From | Jason Wang <> | Subject | [PATCH] macvtap: remove wrong sock_put() in macvtap_put_queue() | Date | Mon, 13 Jun 2011 11:15:19 +0800 |
| |
The calling of sock_put() should be delayed after synchronize_rcu(), otherwise inconsist data may be seen during packets transmitting.
Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/net/macvtap.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 6696e56..ecdb775 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -148,7 +148,6 @@ static void macvtap_put_queue(struct macvtap_queue *q) rcu_assign_pointer(vlan->taps[index], NULL); rcu_assign_pointer(q->vlan, NULL); - sock_put(&q->sk); --vlan->numvtaps; } -- 1.7.1
| |