Messages in this thread Patch in this message | | | From | Greg Dietsche <> | Subject | [PATCH] staging: brcm80211: return false if not a broadcom board | Date | Wed, 15 Jun 2011 17:25:09 -0500 |
| |
This code looks wrong to me. I think it meant to return false if the board's vendor id isn't Broadcom's.
Compile tested only.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> --- drivers/staging/brcm80211/brcmsmac/wlc_bmac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c b/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c index 4534926..ee13238 100644 --- a/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c +++ b/drivers/staging/brcm80211/brcmsmac/wlc_bmac.c @@ -1943,7 +1943,7 @@ static bool wlc_validboardtype(struct wlc_hw_info *wlc_hw) } if (wlc_hw->sih->boardvendor != PCI_VENDOR_ID_BROADCOM) - return goodboard; + goodboard = false; return goodboard; } -- 1.7.2.5
| |