[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c
    On Tue, Jun 14, 2011 at 5:31 PM, Ingo Molnar <> wrote:
    > * Linus Torvalds <> wrote:
    >> On Tue, Jun 14, 2011 at 2:16 PM, Ingo Molnar <> wrote:
    >> >
    >> > I think correctness trumps code size and turning BUG() and BUG_ON()
    >> > into a NOP is just crazy ...
    >> Umm. It's even CRAZIER to turn it into a "compiler generates random code".
    > Sigh, i assumed it got turned into an infinite loop - that is what
    > i've done in a prior patch.
    > You are right, unreachable() is bogus and you'd also be right to
    > suggest that i should not comment on patches after 11pm ;-)

    What we want is a magic GCC trick that says "don't warn about code
    paths that go through here but generate the same code as you would
    without this annotation." I don't think such a thing exists.


     \ /
      Last update: 2011-06-14 23:37    [W:0.020 / U:72.096 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site