Messages in this thread | | | Date | Tue, 14 Jun 2011 23:31:09 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c |
| |
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Tue, Jun 14, 2011 at 2:16 PM, Ingo Molnar <mingo@elte.hu> wrote: > > > > I think correctness trumps code size and turning BUG() and BUG_ON() > > into a NOP is just crazy ... > > Umm. It's even CRAZIER to turn it into a "compiler generates random code".
Sigh, i assumed it got turned into an infinite loop - that is what i've done in a prior patch.
You are right, unreachable() is bogus and you'd also be right to suggest that i should not comment on patches after 11pm ;-)
Thanks,
Ingo
| |