lkml.org 
[lkml]   [2011]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Tue, Jun 14, 2011 at 2:16 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > I think correctness trumps code size and turning BUG() and BUG_ON()
> > into a NOP is just crazy ...
>
> Umm. It's even CRAZIER to turn it into a "compiler generates random code".

Sigh, i assumed it got turned into an infinite loop - that is what
i've done in a prior patch.

You are right, unreachable() is bogus and you'd also be right to
suggest that i should not comment on patches after 11pm ;-)

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-06-14 23:33    [W:0.080 / U:2.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site