Messages in this thread | | | From | Wolfram Sang <> | Subject | [PATCH 0/3] repair RTC subsys (for i.MX) | Date | Wed, 4 May 2011 17:31:25 +0200 |
| |
The recent updates to the RTC subsystem (removing UIE interrupts and use alarms instead) introduced two problems for i.MX (and the subsys in general, I'd think):
a) because registering the rtc now calls get_alarm(), the requirement has been added for a lot of drivers that drvdata is properly set up _before_ registering. rtc-mxc did not do that (probably bad; but as said like a lot of other rtc-drivers currently) and oopsed.
b) the callbacks to the rtc-core for update_irqs have been removed, but irq-handlers are still there, now being unused cruft. In case of rtc-mxc, this is only one if-block, but for rtc-mc13xxx.c this is a seperate handler.
From a glimpse, most platform drivers seem to have at least one of these problems now :( John, am I correct or am I missing something?
Kind regards,
Wolfram
Wolfram Sang (3): rtc: mc13xxx: remove UIE signaling rtc: mxc: fix crash on boot rtc: mxc: remove UIE signaling
drivers/rtc/rtc-mc13xxx.c | 23 ----------------------- drivers/rtc/rtc-mxc.c | 22 +++++++++++----------- 2 files changed, 11 insertions(+), 34 deletions(-)
-- 1.7.2.5
| |