[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support
On Tue, May 31, 2011 at 7:00 PM, Mattias Wallin
<> wrote:
> On 05/31/2011 12:38 PM, Thomas Gleixner wrote:

>>> +++ b/include/linux/clksrc-db8500-prcmu.h

>> Huch, why needs this to be a separate head in include/linux ?
> I will move the header file to mach-ux500/include/mach/. Ok?
> (I have long time ago been thought to avoid include mach headers from the
> drivers. But if I understand it correct it is not true any more and in this
> case it certainly makes no sense since I break that rule myself.)

Keeping it under include/linux is probably wise since we want drivers
OUT of the ARM tree, but I don't know if there is much consensus on that?

I was more understanding the question as why it was needed at all.

Does it work to register the clocksource with say a core_initcall()
and avoid the header altogether?

Else a header is needed since we need to call out from the platform timer
init function to this clocksource to register it.

Linus Walleij

 \ /
  Last update: 2011-05-31 23:21    [W:0.101 / U:4.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site