Messages in this thread | | | Date | Wed, 1 Jun 2011 10:37:16 +0200 | Subject | Re: [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support | From | Linus Walleij <> |
| |
2011/6/1 Russell King - ARM Linux <linux@arm.linux.org.uk>: > On Tue, May 31, 2011 at 11:18:25PM +0200, Linus Walleij wrote: >> Keeping it under include/linux is probably wise since we want drivers >> OUT of the ARM tree, but I don't know if there is much consensus on that? > > Header files private to a driver should be alongside the driver. Look > at drivers/net or drivers/scsi for plenty of examples. > > Just because its a header file does not mean it must be in some directory > with 'include' in its path. The only reason to put it in include/linux > is if it contains stuff which needs to be shared outside of the driver > (eg, with arches).
I agree. Right now I have a creepy feeling that many drivers are just putting headers in <mach/foo.h> out of habit, when plain "foo.h" in working dir or <linux/subsystem/foo.h> is what is really apropriate.
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |