Messages in this thread | | | Date | Tue, 3 May 2011 09:12:15 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/4] perf: Add persistent event facilities |
| |
On Tue, May 03, 2011 at 02:40:46AM -0400, Ingo Molnar wrote: > I really like this new kernel/events/ subdirectory you created -
Yeah, this was your suggestion a couple of months ago, I just picked it up.
> we could move the other perf_events.c facilities there as well, and > maybe split up the file a bit, it's 7.5 KLOC now which is a bit > excessive.
Right, so I left perf_event.c as a whole on purpose (only renamed) because it makes more sense IMHO for someone who actually wrote it to split it in logical parts (^hint hint^). I mean, I could do it too but it'll take me much more time :).
> We should probably do that before adding kernel/events/persistent.c - wanna do > those changes? Initial commit should be a mostly-rename thing: > kernel/perf_events.c could move into kernel/events/core.c or so - and then we > could split the core up some more, into various facilities. > > [ kernel/hw_breakpoint.c could possibly move into kernel/events/hw_breakpoint.c > file as well - if Frederic acks it. ]
Yeah, no problem.
Thanks for the review, btw.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
| |