lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] perf: Add persistent event facilities

* Borislav Petkov <bp@amd64.org> wrote:

> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Add a barebones implementation for registering persistent events with
> perf. For that, we don't destroy the buffers when they're unmapped;
> also, we map them read-only so that multiple agents can access them.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
> include/linux/perf_event.h | 22 +++++++++++++++-
> kernel/events/Makefile | 2 +-
> kernel/events/core.c | 29 ++++++++++++++++++---
> kernel/events/persistent.c | 59 ++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 105 insertions(+), 7 deletions(-)
> create mode 100644 kernel/events/persistent.c

I really like this new kernel/events/ subdirectory you created - we could move
the other perf_events.c facilities there as well, and maybe split up the file a
bit, it's 7.5 KLOC now which is a bit excessive.

We should probably do that before adding kernel/events/persistent.c - wanna do
those changes? Initial commit should be a mostly-rename thing:
kernel/perf_events.c could move into kernel/events/core.c or so - and then we
could split the core up some more, into various facilities.

[ kernel/hw_breakpoint.c could possibly move into kernel/events/hw_breakpoint.c
file as well - if Frederic acks it. ]

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-03 08:43    [W:0.349 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site