lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Kernel crash after using new Intel NIC (igb)

* Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Le samedi 28 mai 2011 à 20:04 +0200, Ingo Molnar a écrit :
> > * Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> > > > +static inline int atomic_add_unless(atomic_t *v, int a, int u)
> > > > +{
> > > > + return __atomic_add_unless(v, a, u) != u;
> > > > }
> > > >
> > > > #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
> > >
> > > As I said, atomic_add_unless() has several implementations in
> > > various arches. You must take care of all, not only x86.
> >
> > It's a bit sad to see local hacks to generic facilities committed
> > upstream like that.
> >
>
> Again, its a stable candidate patch, on a file that had many changes in
> recent kernels.
>
> I felt this was the right thing to do, to ease stable teams work.

Yes and i do this all the time as well, to make life easier for the
stable team.

What wasnt fine was to not follow up the backportable hack with the
proper patch though. Or did you plan to do that yourself if Arun
fails to complete the generic variant? (in which case my remark is
moot)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-29 09:41    [W:0.106 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site