lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Kernel crash after using new Intel NIC (igb)
    From
    Date
    Le samedi 28 mai 2011 à 20:04 +0200, Ingo Molnar a écrit :
    > * Eric Dumazet <eric.dumazet@gmail.com> wrote:
    >
    > > > +static inline int atomic_add_unless(atomic_t *v, int a, int u)
    > > > +{
    > > > + return __atomic_add_unless(v, a, u) != u;
    > > > }
    > > >
    > > > #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
    > >
    > > As I said, atomic_add_unless() has several implementations in
    > > various arches. You must take care of all, not only x86.
    >
    > It's a bit sad to see local hacks to generic facilities committed
    > upstream like that.
    >

    Again, its a stable candidate patch, on a file that had many changes in
    recent kernels.

    I felt this was the right thing to do, to ease stable teams work.

    Its not like there is an urgent need for this atomic_add_unless_return()
    thing that we have to worry right now.



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-29 09:37    [W:0.024 / U:302.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site