Messages in this thread | | | Date | Sat, 28 May 2011 18:17:57 +0800 | From | Greg KH <> | Subject | Re: [PATCH 2/3] introduce intel_rapl driver |
| |
On Thu, May 26, 2011 at 04:34:17PM +0800, Zhang Rui wrote: > +/* > + * Intel RAPL interface driver > + * > + * Copyright (C) 2010-2011 Zhang Rui <rui.zhang@intel.com> > + * > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or (at > + * your option) any later version.
Are you really sure about "any later version"? I didn't think that was the default rule of Intel kernel code these days, have you verified this exception is ok?
> + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, write to the Free Software Foundation, Inc., > + * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
These two paragraphs are not needed, and the last one is never needed unless you want to track the office movements of the FSF for the next 50+ years and always update this file because of that.
greg k-h
| |