lkml.org 
[lkml]   [2011]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:perf/urgent] perf symbols: Handle /proc/sys/kernel/kptr_restrict

    * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:

    > > Had you done this you'd have immediately noticed that the individual
    > > lines are *way* too large to fit on even large terminals. Please
    > > break such messages in a much shorter fashion - we want the error
    > > messages we output to be readable even on relatively small (80col)
    > > terminals.
    >
    > But it would reflow, no?

    Not on all terminals. For example my terminal will just cut anything
    beyond the col limit:

    # perf report --stdio
    No kallsyms or vmlinux with build-id 122214021a666675f6e5ff97d70a85ce7139c0e7 was found
    [kernel.kallsyms] with build id 122214021a666675f6e5ff97d70a85ce7139c0e7 not found, continuing without s
    Kernel address maps (/proc/{kallsyms,modules}) were restricted, check /proc/sys/kernel/kptr_restrict bef

    So we generally want to generate error messages to look good on col80
    - it should not be hard here, right?

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-05-27 10:41    [W:0.020 / U:123.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site