Messages in this thread | | | From | Alexander Stein <> | Subject | Re: pch_gpio: Support new device ML7223 | Date | Wed, 25 May 2011 14:09:46 +0200 |
| |
Hello Tomoya,
On Monday 09 May 2011 12:58:49 Tomoya wrote: > diff --git a/drivers/gpio/pch_gpio.c b/drivers/gpio/pch_gpio.c > index f970a5f..36919e7 100644 > --- a/drivers/gpio/pch_gpio.c > +++ b/drivers/gpio/pch_gpio.c > @@ -283,8 +283,10 @@ static int pch_gpio_resume(struct pci_dev *pdev) > #define pch_gpio_resume NULL > #endif > > +#define PCI_VENDOR_ID_ROHM 0x10DB
Should this be moved to pci_ids.h?
> static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = { > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) }, > + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
Likewise for the product ID. While at it, the ID for EG20T could also be moved in a separate patch.
> { 0, } > }; > MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);
Regards, Alexander
| |