lkml.org 
[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: pch_gpio: Support new device ML7223
Date
On Thursday 26 May 2011 03:24:55 Tomoya MORINAGA wrote:
> > From: Alexander Stein [mailto:alexander.stein@systec-electronic.com]
> > Sent: Wednesday, May 25, 2011 9:10 PM
> >
> > > #define pch_gpio_resume NULL #endif
> > >
> > > +#define PCI_VENDOR_ID_ROHM 0x10DB
> >
> > Should this be moved to pci_ids.h?
>
> OK.
> I will move this to pci_ids.h.
>
> > > static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
> > >
> > > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> > >
> > > + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
> >
> > Likewise for the product ID. While at it, the ID for EG20T
> > could also be moved in a separate patch.
>
> We have already upstreamed not only GPIO but also many device drivers(GBE,
> USBDEV,DMA,UART,SPI,I2C,CAN). Do you mean we must move these device
> definitions to pci_ids.h?

I just meant to move 0x8803 from the line above into pci_ids.h. It is
unrelated to your patch.
And if this _must_ be moved to pci_ids.h I'm the wrong person to decide.

Regards,
Alexander


\
 
 \ /
  Last update: 2011-05-26 08:11    [W:0.065 / U:2.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site