Messages in this thread | | | Subject | Re: [PATCH v3] x86, vt-d: enable x2apic opt out | From | David Woodhouse <> | Date | Tue, 24 May 2011 08:38:47 +0100 |
| |
On Tue, 2011-05-24 at 05:18 +0100, Valdis.Kletnieks@vt.edu wrote: > Do we want an actual WARN there, complete with stack traceback and > all? > > Or did you intend a pr_warn or printk(KERN_WARNING or similar?
The traceback has been very useful in other BIOS issues, because it gets tracked and counted on kerneloops.org along with platform identification. So we have been able to track down the major offenders of some of the most egregious BIOS stupidities and make *some* progress on getting them to improve the untested dross they habitually turn out.
On *this* occasion perhaps a printk might suffice. After all, this X2APIC_OPT_OUT was invented specifically as a way to allow the BIOS engineers to get away without fixing their bugs. But then again, it would also be useful to track how many people are doing it, and I cannot think of a *legitimate* reason for a BIOS having to set it. So on balance I'm happier with the WARN().
-- dwmw2
| |