Messages in this thread | | | Subject | Re: [PATCH v3] x86, vt-d: enable x2apic opt out | From | Valdis.Kletnieks@vt ... | Date | Tue, 24 May 2011 08:13:28 -0400 |
| |
On Tue, 24 May 2011 08:38:47 BST, David Woodhouse said: > On Tue, 2011-05-24 at 05:18 +0100, Valdis.Kletnieks@vt.edu wrote: > > Do we want an actual WARN there, complete with stack traceback and > > all? > > > > Or did you intend a pr_warn or printk(KERN_WARNING or similar? > > The traceback has been very useful in other BIOS issues, because it gets > tracked and counted on kerneloops.org along with platform > identification. So we have been able to track down the major offenders > of some of the most egregious BIOS stupidities and make *some* progress > on getting them to improve the untested dross they habitually turn out.
Oh OK... that probably is a good idea then. [unhandled content-type:application/pgp-signature] | |