Messages in this thread | | | Date | Fri, 29 Apr 2011 18:32:34 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [media] dib0700: get rid of on-stack dma buffers |
| |
Em 04-04-2011 04:42, Patrick Boettcher escreveu: > Hi Florian, > > On Sun, 3 Apr 2011, Florian Mickler wrote: > >> Hi, >> >> since I got no reaction[1] on the vp702x driver, I proceed with the >> dib0700. >> >> There are multiple drivers in drivers/media/dvb/dvb-usb/ which use >> usb_control_msg to perform dma to stack-allocated buffers. This is a bad idea >> because of cache-coherency issues and on some platforms the stack is mapped >> virtually and also lib/dma-debug.c warn's about it at runtime. >> >> Patches to ec168, ce6230, au6610 and lmedm04 were already tested and reviewed >> and submitted for inclusion [2]. Patches to a800, vp7045, friio, dw2102, m920x >> and opera1 are still waiting for for review and testing [3]. >> >> This patch to dib0700 is a fix for a warning seen and reported by Zdenek >> Kabalec in Bug #15977 [4]. >> >> Florian Mickler (2): >> [media] dib0700: get rid of on-stack dma buffers > > For this one we implemented an alternative. See here: > > http://git.linuxtv.org/pb/media_tree.git?a=commit;h=16b54de2d8b46e48c5c8bdf9b350eac04e8f6b46 > > which I pushed, but obviously forgot to send the pull-request. > > This is done now.
And I obviously forgot to pick ;) Ok, I'm applying Oliver Grenie's version and marking Florian's version as superseded at patchwork.
> For the second patch I will incorperate it as soon as I find the time.
As it is a trivial fix, I'll be picking it directly.
> > best regards, > -- > > Patrick > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |