Messages in this thread | | | Date | Sat, 23 Apr 2011 15:45:28 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins |
| |
Hi Grant,
On Tue, 19 Apr 2011 08:44:29 -0600, Grant Likely wrote: > On Tue, Apr 19, 2011 at 6:53 AM, Jean Delvare <khali@linux-fr.org> wrote: > > I need this to handle SMBus multiplexing on my Asus Z8NA-D6 board. It > > has an ICH10, I've added support for older ICH chips in case someone > > needs it, as it was relatively simply to do that. > > Your timing is impeccable. You're getting caught up in the big gpio > driver consolidation. :-) > > Most gpio drivers end up looking pretty darn similar. Instead of > writing the same types of drivers over and over again, the new > approach is to try and consolidate the mmio drivers down to using > basic_mmio_gpio.c. > > In this particular case, you've got a PCI device which looks to be > going into config space to get some information about how the chip is > layed out. What I would do is keep your existing pci probe & remove > hooks, but use them to create and register child basic_mmio_gpio > platform_devices for each gpio bank.
I can see there are still discussions going on with regards to basic_mmio_gpio. To be honest, I don't have any opinion on this. My only concern is that I have driver code which appears to work well enough for me and I would like it to be merged in kernel 2.6.40.
So my questions are as follows: what do I get to do for it to happen? If there a chance that my driver as it currently exists (i.e. not using basic_mmio_gpio) gets reviewed and merged? Or do I have to rewrite it using basic_mmio_gpio to get a chance?
I can't see any driver currently relying on basic_mmio_gpio in the kernel tree. Why is that, and why would my driver have to, if none else did yet?
And a technical question (which makes me feel somewhat ashamed as I guess I really should know the answer): the ICH is using I/O ports for GPIO control, not a memory mapping. Would basic_mmio_gpio work for it still?
Thanks, -- Jean Delvare
| |