Messages in this thread | | | Date | Tue, 19 Apr 2011 16:57:46 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins |
| |
> Doing a platform device is one solution that is pretty simple to > implement and I don't think adding child devices is at all a problem. > However, I'm not mandating that approach, and if you or Jean prefer to > abstract out the gpio accessors from basic_mmio_gpio(), then that is > fine by me. The key issue it to avoid merging yet another, probably > subtly broken, set of GPIO accessor functions if it can at all be > avoided.
As is adding a set of subtly broken attempts to create device stacks that then get into funny sysfs and power management tangles. As well as being about 12K larger due to the need to suck in an extra module.
I can see the point of splitting out the accessors but if thats a module of its own then thats another 8K we don't need to waste on a few hundred bytes of utterly trivial code.
| |