Messages in this thread | | | Date | Fri, 22 Apr 2011 15:35:57 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] export kernel call get_task_comm(). |
| |
On Fri, 22 Apr 2011, james_p_freyensee@linux.intel.com wrote:
> From: J Freyensee <james_p_freyensee@linux.intel.com> > > This allows drivers who call this function to be compiled modularly. > Otherwise, a driver who is interested in this type of functionality > has to implement their own get_task_comm() call, causing code > duplication in the Linux source tree. > > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
I still suggest that we implement finer-grained protection for tsk->comm through get_task_comm(), though, because it's going to be difficult to know whether task_lock(tsk) is held in all contexts we'll want to call it; task_lock(tsk) is used to protect many members of task_struct.
| |