lkml.org 
[lkml]   [2011]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] export kernel call get_task_comm().
    From
    Date
    On Fri, 2011-04-22 at 15:35 -0700, David Rientjes wrote:
    > On Fri, 22 Apr 2011, james_p_freyensee@linux.intel.com wrote:
    >
    > > From: J Freyensee <james_p_freyensee@linux.intel.com>
    > >
    > > This allows drivers who call this function to be compiled modularly.
    > > Otherwise, a driver who is interested in this type of functionality
    > > has to implement their own get_task_comm() call, causing code
    > > duplication in the Linux source tree.
    > >
    > > Signed-off-by: J Freyensee <james_p_freyensee@linux.intel.com>
    >
    > Acked-by: David Rientjes <rientjes@google.com>
    >
    > I still suggest that we implement finer-grained protection for tsk->comm
    > through get_task_comm(), though, because it's going to be difficult to
    > know whether task_lock(tsk) is held in all contexts we'll want to call it;
    > task_lock(tsk) is used to protect many members of task_struct.

    Okay, but how about accepting this as step 1, then investigate a finer
    grained lock structure as step 2?



    \
     
     \ /
      Last update: 2011-04-23 00:47    [W:2.335 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site