Messages in this thread | | | Subject | Re: [PATCH v2] rfkill: Regulator consumer driver for rfkill | From | Johannes Berg <> | Date | Wed, 13 Apr 2011 11:19:16 +0200 |
| |
On Wed, 2011-04-13 at 10:44 +0200, Antonio Ospite wrote: > On Tue, 12 Apr 2011 13:44:02 +0200 > Johannes Berg <johannes@sipsolutions.net> wrote: > > > On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote: > > > > > > + * static struct regulator_consumer_supply pcap_regulator_V6_consumers [] = { > > > > + * { .dev_name = "rfkill-regulator.0", supply = "vrfkill" }, > > > > + * }; > > > > > > It's a comment, but it should be .supply = (missing the .) > > > > > well spotted, I'll fix this.
This is the comment I was referring to -- I got confused and thought this was a struct rfkill_regulator_platform_data.
> That's how the regulator framework works, I know Mark already replied to > you but I try to elaborate more for the records and to organize my > thoughts about that: [snip explanation]
Thanks, ok, I'm just not familiar with the regulator framework and got confused about the various structs involved.
So the only thing I see wrong is the missing . above, not sure if you care enough to resend :-)
johannes
| |