lkml.org 
[lkml]   [2011]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] rfkill: Regulator consumer driver for rfkill
    From
    Date
    On Tue, 2011-04-12 at 13:41 +0200, Johannes Berg wrote:

    > > + * static struct regulator_consumer_supply pcap_regulator_V6_consumers [] = {
    > > + * { .dev_name = "rfkill-regulator.0", supply = "vrfkill" },
    > > + * };
    >
    > It's a comment, but it should be .supply = (missing the .)
    >
    > > + if (pdata->name == NULL || pdata->type == 0) {
    > > + dev_err(&pdev->dev, "invalid name or type in platform data\n");
    > > + return -EINVAL;
    > > + }
    > > +
    > > + vcc = regulator_get_exclusive(&pdev->dev, "vrfkill");
    >
    > Wasn't that supposed to use pdata->supply? Actually, there's no member
    > "supply" in the struct?

    Oh wait, I think I just misunderstood how this works. But if the name is
    "vrfkill" how does that really work with multiple instances?

    johannes



    \
     
     \ /
      Last update: 2011-04-12 13:47    [W:0.024 / U:31.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site