Messages in this thread | | | From | "Nori, Sekhar" <> | Date | Wed, 13 Apr 2011 21:12:05 +0530 | Subject | RE: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci |
| |
On Wed, Apr 13, 2011 at 20:52:05, Ben Gardiner wrote:
> >> --- a/arch/arm/mach-davinci/devices-da8xx.c > >> +++ b/arch/arm/mach-davinci/devices-da8xx.c > >> @@ -324,6 +324,12 @@ int __init da8xx_register_i2c(int instance, > >> else > >> return -EINVAL; > >> > >> + /* > >> + * Both the DA850 and DA830 have an I2C controller which has the > >> + * ICPFUNC et. al. registers > >> + */ > >> + pdata->has_pfunc = 1; > > > > The I2C driver implements a default platform data > > so it should actually be legal for a DA8x board to > > pass NULL platform data. In that case this line > > will crash. > > Good catch, thanks. > > > [...] You should either check for pdata to > > be NULL or just let each board choose whether it > > needs recovery (I think the better option). > > I understand "check for pdata to be NULL." If you think it is the > better option I'd be happy to implement it but I don't understand how > to implement "let each board choose whether it needs recovery."
This is done by just setting has_pfunc = 1 in the davinci_i2c_platform_data defined in the board file.
Thanks, Sekhar
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |