lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: mce: don't print "human readable" message for corrected errors
On Wed, Apr 13, 2011 at 09:14:33AM +0200, Borislav Petkov wrote:

[..]

> So maybe we could drop the default notifier and do in print_mce():
>
> if (notifier_chain_empty(&x86_mce_decoder_chain))
> pr_emerg(HW_ERR "Run the message through 'mcelog --ascii' to decode.\n");
>
> I think this could work, let me cook up something.

Ok, I'm sending what I scratched up as a reply to this mail. They remove
the default notifier and use an atomic flag to distinguish the cases
between when we have a decoder or not.

This is marginally better in the sense that we don't have to call into
the notifier chain if there are no notifier calls on it so it saves us
a call in the UC case. Also, it drops the tainting for CEs and testing
this by injecting DRAM CECCs leaves /proc/sys/kernel/tainted at 0.

I still have to test the UC case but for that I'll have to dust off my
patchset which implements hw MCE injection first.

To be continued...

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


\
 
 \ /
  Last update: 2011-04-13 15:27    [W:0.059 / U:2.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site