Messages in this thread | | | Date | Wed, 13 Apr 2011 15:24:09 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH]: mce: don't print "human readable" message for corrected errors |
| |
On Wed, Apr 13, 2011 at 09:14:33AM +0200, Borislav Petkov wrote:
[..]
> So maybe we could drop the default notifier and do in print_mce(): > > if (notifier_chain_empty(&x86_mce_decoder_chain)) > pr_emerg(HW_ERR "Run the message through 'mcelog --ascii' to decode.\n"); > > I think this could work, let me cook up something.
Ok, I'm sending what I scratched up as a reply to this mail. They remove the default notifier and use an atomic flag to distinguish the cases between when we have a decoder or not.
This is marginally better in the sense that we don't have to call into the notifier chain if there are no notifier calls on it so it saves us a call in the UC case. Also, it drops the tainting for CEs and testing this by injecting DRAM CECCs leaves /proc/sys/kernel/tainted at 0.
I still have to test the UC case but for that I'll have to dust off my patchset which implements hw MCE injection first.
To be continued...
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
| |