lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: mce: don't print "human readable" message for corrected errors
On Tue, Apr 12, 2011 at 10:00:34PM -0500, Russ Anderson wrote:
> > I'm thinking remove the TAINT for CEs and don't call the default
> > notifier if it is the only notifier call registered. Maybe something like
> >
> > if (num_notifiers(&x86_mce_decoder_chain) > 1)
> > atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, &m);
> >
> > or since the notifiers are priority sorted, don't call notifiers with -1
> > prio.
> >
> > Or something to that effect.
>
> What is the point of having a default notifier if it doesn't get called?

Well, the thing is, we call the same notifier chain in the event of
both correctable and uncorrectable errors. But to be honest, if we shut
up the default pr_emerg() calls with "no human readable.." in the CEs'
case, then we don't really need it in the UEs' case either, IMO.

The only half-way sensible info we print is

"Run the message through 'mcelog --ascii' to decode.\n"

on UE because there we print MCA regs to the console where mcelog can
actually decode them, and this should be a hint to the user to do so.

In the CEs case, no such info comes out and there's no need for those
printks to flood the logs.

So maybe we could drop the default notifier and do in print_mce():

if (notifier_chain_empty(&x86_mce_decoder_chain))
pr_emerg(HW_ERR "Run the message through 'mcelog --ascii' to decode.\n");

I think this could work, let me cook up something.

> Any consideration of adding thresholding (ie only log the first X number
> of corrected errors) as is done on IA64? (see arch/ia64/kernel/mca.c)

Yep, this is in the works with a RAS daemon that should collect all
error info in userspace and do all policies there. We might even drop
the spitting in the system logs almost completely and I know this'll
make a lot of people happy :).

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2011-04-13 09:17    [W:0.068 / U:3.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site