Messages in this thread | | | From | "Voss, Nikolaus" <> | Date | Mon, 11 Apr 2011 11:38:34 +0200 | Subject | RE: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs |
| |
Hi,
> What about something like this? > > /* disable all interrupts to avoid premature irq triggering */ > spi_writel(as, IDR, 0xffffffff);
I implemented it this way the first time, but on a second approach I used the more specific variant.
That way it is kept symmetric to the irq enable part in the transfer method which enables no more than the irqs disabled in my patch. And I generally feel better when not writing live values to don't care bits ;-).
It's a matter of taste after all.
Best regards, Nikolaus Voss
| |