lkml.org 
[lkml]   [2011]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs
Hi,

> What about something like this?
>
> /* disable all interrupts to avoid premature irq triggering */
> spi_writel(as, IDR, 0xffffffff);

I implemented it this way the first time, but on a second approach I used
the more specific variant.

That way it is kept symmetric to the irq enable part in the transfer method
which enables no more than the irqs disabled in my patch. And I generally
feel better when not writing live values to don't care bits ;-).

It's a matter of taste after all.

Best regards,
Nikolaus Voss



\
 
 \ /
  Last update: 2011-04-11 11:41    [W:0.136 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site