lkml.org 
[lkml]   [2011]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs
Le 11/04/2011 08:53, Voss, Nikolaus :
> When restarting a kernel using kexec, filled rx buffers on SPI master
> interface reliably crash the kernel. This patch disables rx interrupts
> on startup to avoid this. Interrupts will be regulary enabled at start
> of a new SPI master transfer.
>
> Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
> drivers/spi/atmel_spi.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/atmel_spi.c b/drivers/spi/atmel_spi.c
> index 1a478bf..d17f14c 100644
> --- a/drivers/spi/atmel_spi.c
> +++ b/drivers/spi/atmel_spi.c
> @@ -811,6 +811,9 @@ static int __init atmel_spi_probe(struct platform_device *pdev)
> as->irq = irq;
> as->clk = clk;
>
> + /* disable rx interrupts to avoid premature irq triggering */
> + spi_writel(as, IDR, SPI_BIT(RXBUFF) | SPI_BIT(ENDRX) | SPI_BIT(OVRES));
> +
> ret = request_irq(irq, atmel_spi_interrupt, 0,
> dev_name(&pdev->dev), master);
> if (ret)


--
Nicolas Ferre



\
 
 \ /
  Last update: 2011-04-18 10:31    [W:0.048 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site