Messages in this thread Patch in this message | | | Date | Thu, 31 Mar 2011 12:42:19 GMT | From | tip-bot for Peter Zijlstra <> | Subject | [tip:perf/urgent] perf: Fix task_struct reference leak |
| |
Commit-ID: fd1edb3aa2c1d92618d8f0c6d15d44ea41fcac6a Gitweb: http://git.kernel.org/tip/fd1edb3aa2c1d92618d8f0c6d15d44ea41fcac6a Author: Peter Zijlstra <a.p.zijlstra@chello.nl> AuthorDate: Mon, 28 Mar 2011 13:13:56 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Thu, 31 Mar 2011 13:02:56 +0200
perf: Fix task_struct reference leak
sys_perf_event_open() had an imbalance in the number of task refs it took causing memory leakage
Cc: Jiri Olsa <jolsa@redhat.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: stable@kernel.org # .37+ Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> LKML-Reference: <new-submission> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- kernel/perf_event.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kernel/perf_event.c b/kernel/perf_event.c index 2616909..27960f1 100644 --- a/kernel/perf_event.c +++ b/kernel/perf_event.c @@ -6531,6 +6531,11 @@ SYSCALL_DEFINE5(perf_event_open, goto err_alloc; } + if (task) { + put_task_struct(task); + task = NULL; + } + /* * Look up the group leader (we will attach this event to it): */
| |