Messages in this thread Patch in this message | | | From | Richard Genoud <> | Subject | [PATCH] ad525x_dpot: [BUG] eeprom command send instead of dec/inc all commands | Date | Sat, 12 Mar 2011 14:08:21 +0100 |
| |
When a DEC_ALL or INC_ALL command is issued, an eeprom command is send. This is because DPOT_DEC_ALL (DPOT_ADDR_CMD | 0x30) and DPOT_INC_ALL (DPOT_ADDR_CMD | 0x58) defines overlap with DPOT_ADDR_EEPROM (0x20).
So, DPOT_ADDR_CMD bit should be tested before DPOT_ADDR_EEPROM bit.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com> --- drivers/misc/ad525x_dpot.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 7cb9110..b6c5391 100644 --- a/drivers/misc/ad525x_dpot.c +++ b/drivers/misc/ad525x_dpot.c @@ -289,8 +289,6 @@ static s32 dpot_write_spi(struct dpot_data *dpot, u8 reg, u16 value) } val = DPOT_SPI_RDAC | (reg & DPOT_RDAC_MASK); } - } else if (reg & DPOT_ADDR_EEPROM) { - val = DPOT_SPI_EEPROM | (reg & DPOT_RDAC_MASK); } else if (reg & DPOT_ADDR_CMD) { switch (reg) { case DPOT_DEC_ALL_6DB: @@ -306,6 +304,8 @@ static s32 dpot_write_spi(struct dpot_data *dpot, u8 reg, u16 value) val = DPOT_SPI_INC_ALL; break; } + } else if (reg & DPOT_ADDR_EEPROM) { + val = DPOT_SPI_EEPROM | (reg & DPOT_RDAC_MASK); } else if (reg & DPOT_ADDR_OTP) { if (dpot->uid == DPOT_UID(AD5291_ID) || dpot->uid == DPOT_UID(AD5292_ID)) { -- 1.7.1
| |