Messages in this thread | | | Date | Tue, 01 Mar 2011 09:11:20 -0700 | From | David Ahern <> | Subject | Re: [PATCH 4/6] perf script: dump software events too |
| |
On 03/01/2011 08:11 AM, Frederic Weisbecker wrote: > > Why shouldn't it be designed to dump software events? It's called print_event(). > Its current version is rather something I would call "limited". But it > was not designed > to be limited.
That's because its origins are trace specific. Per last week's thread, perf-script was perf-trace until Nov 2010. perf-script deals with tracepoints.
> > Ideally, we should have print_tracepoint_event() in > trace-event-parse.c, print_software_event() > where you want, and have print_event() in builtin-script.c that wraps on those.
process_event does not take the event sample, it takes elements of it:
struct scripting_ops { ... void (*process_event) (int cpu, void *data, int size, unsigned long long nsecs, char *comm); ... };
David
| |