Messages in this thread | | | Date | Tue, 8 Feb 2011 14:40:49 +0100 | Subject | Re: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function. | From | Belisko Marek <> |
| |
On Wed, Jan 26, 2011 at 3:30 PM, Dan Carpenter <error27@gmail.com> wrote: > Also when it does: > memcpy(ft1000dev->tx_buf, *pUcFile, byte_length); > > That should probably be: > memcpy(ft1000dev->tx_buf, *pUcFile, word_length * 4); No this shouldn't because before you have additional check: if (byte_length && ((byte_length % 64) == 0)) byte_length += 4;
if (byte_length < 64) byte_length = 68; So in my opinion byte_length should stay. > > Otherwise we're probably copying garbage from beyond the end of *pUcFile > to the ->tx_buf. ft1000dev->tx_buf is hopefully initialized to zero at > this point? Yes usb_init_urb set it to zeroes. > > regards, > dan carpenter > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
thanks,
marek
-- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |