Messages in this thread | | | Date | Wed, 26 Jan 2011 17:30:45 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 4/5] staging: ft1000: Fix coding style in write_blk_fifo() function. |
| |
Also when it does: memcpy(ft1000dev->tx_buf, *pUcFile, byte_length);
That should probably be: memcpy(ft1000dev->tx_buf, *pUcFile, word_length * 4);
Otherwise we're probably copying garbage from beyond the end of *pUcFile to the ->tx_buf. ft1000dev->tx_buf is hopefully initialized to zero at this point?
regards, dan carpenter
| |