lkml.org 
[lkml]   [2011]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip] perf: x86, add SandyBridge support
From
Date
On Thu, 2011-02-24 at 22:25 +0800, Andi Kleen wrote:
> On Thu, Feb 24, 2011 at 10:11:24PM +0800, Lin Ming wrote:
> > On Thu, 2011-02-24 at 22:02 +0800, Andi Kleen wrote:
> > > > + [ C(OP_READ) ] = {
> > > > + [ C(RESULT_ACCESS) ] = 0x04d1, /* MEM_LOAD_UOPS_RETIRED.LLC_HIT */
> > > > + [ C(RESULT_MISS) ] = 0x0,
> > > > + },
> > > > + [ C(OP_WRITE) ] = {
> > > > + [ C(RESULT_ACCESS) ] = 0x0424, /* L2_RQSTS.RFO_HITS */
> > > > + [ C(RESULT_MISS) ] = 0x0824, /* L2_RQSTS.RFO_MISS */
> > >
> > > No! You really need offcore here. L2 is not LLC!!!
> > > See the offcore patchkit which fixes this for Nehalem.
> >
> > Yes, I know that.
> > But I write it like this for now since the offcore patchkit has not been
> > merged yet.
>
> It's just wrong. Please don't merge more bugs.

OK. I'll fix it and include this patch in the offcore patchkit.

>
> -Andi
>




\
 
 \ /
  Last update: 2011-02-24 15:57    [W:0.061 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site