lkml.org 
[lkml]   [2011]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes
Date


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Friday, February 18, 2011 1:28 AM
> To: Guan Xuetao
> Cc: linux-kernel@vger.kernel.org; linux-arch@vger.kernel.org; 'Greg KH'
> Subject: Re: [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes
>
> On Sunday 13 February 2011, Guan Xuetao wrote:
> > This patch includes generic codes for memory management.
> >
> > Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> > +#ifdef __io
> > +void __iomem *ioport_map(unsigned long port, unsigned int nr)
> > +{
> > + /* we map PC lagcy 64K IO port to PCI IO space 0x80030000 */
> > + return (void __iomem *) (unsigned long)
> > + io_p2v((port & 0xffff) + PKUNITY_PCILIO_BASE);
> > +}
>
> Interestingly, this function looks completely correct, but I don't see
> the definition for __io, so I suspect that the function is not actually
> getting used.
When I want to use pci device driver, I will define __io and use ioport_map for drivers.
It is obviously a trick. And with your patch for asm-generic/io.h, these codes could be removed.

>
> Best make this unconditional. The code is obviously derived from the
> ARM version, which uses a macro called __io, but you don't need this
> macro because you only support one SoC platform.
>
> Arnd

Thanks & Regards.
Guan Xuetao



\
 
 \ /
  Last update: 2011-02-22 15:19    [W:0.123 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site