Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes | Date | Thu, 17 Feb 2011 18:28:15 +0100 |
| |
On Sunday 13 February 2011, Guan Xuetao wrote: > This patch includes generic codes for memory management. > > Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> +#ifdef __io > +void __iomem *ioport_map(unsigned long port, unsigned int nr) > +{ > + /* we map PC lagcy 64K IO port to PCI IO space 0x80030000 */ > + return (void __iomem *) (unsigned long) > + io_p2v((port & 0xffff) + PKUNITY_PCILIO_BASE); > +}
Interestingly, this function looks completely correct, but I don't see the definition for __io, so I suspect that the function is not actually getting used.
Best make this unconditional. The code is obviously derived from the ARM version, which uses a macro called __io, but you don't need this macro because you only support one SoC platform.
Arnd
| |